-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
C elegens metadata #353
C elegens metadata #353
Conversation
XX and XO appear to be officially designated for this species, so yes perfectly fine by me |
The other life cycle stuff is a part of the ongoing discussion for handling age: #209 |
Co-authored-by: Ryan Ly <[email protected]>
Co-authored-by: Ryan Ly <[email protected]>
Co-authored-by: Ryan Ly <[email protected]>
Just need a couple tests and this is good to go |
@rly I remember you mentioning something about the reasons the DANDI tests are failing - can you confirm there is no easy way to fix the CI here? |
The tests fail because dandi raises DeprecationWarnings into errors. We have a fix in the dev branch of PyNWB that we haven't released yet. I'm getting to it... |
Thanks for confirming, no huge rush on my end I just wanted to know for sure |
Co-authored-by: Ryan Ly <[email protected]>
Codecov Report
@@ Coverage Diff @@
## dev #353 +/- ##
==========================================
- Coverage 91.13% 90.98% -0.16%
==========================================
Files 20 20
Lines 1117 1120 +3
==========================================
+ Hits 1018 1019 +1
- Misses 99 101 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
|
@rly Good to merge? |
Motivation
From conversation with Daniel Sprague:
What do you think, @CodyCBakerPhD ?