Should check_subject_exists be CRITICAL? (i.e., should it block DANDI upload) #393
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CodyCBakerPhD
changed the title
|
This check is critical in the DANDI config: https://github.com/NeurodataWithoutBorders/nwbinspector/blob/dev/src/nwbinspector/internal_configs/dandi.inspector_config.yaml |
|
Right; the remark from the user was that they needed to know ahead of time to set their config to DANDI level to get informed about this Otherwise, 'SUGGESTION' level messages are usually viewed as 'safe to ignore' but they remarked that this likely could have led them to spend a fair amount of time writing a big NWB file only to learn that it needed a subject added to it to be valid for DANDI upload Maybe bumping it up to a VIOLATION could help emphasize the importance? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Noticed when looking at the report from someone at the User Days, this check should maybe have a higher importance since dandi upload is actually impossible if a Subject is not in the file