Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update copyright year so doesn't look stale #449

Merged
merged 5 commits into from
Aug 12, 2024

Conversation

yarikoptic
Copy link
Contributor

Motivation

otherwise looks "old"

@CodyCBakerPhD
Copy link
Collaborator

This could get annoying to update every year - to me the copyright is just the year it was created, so actually the older the better (showing stability/maturity of package)

@bendichter What do you think?

@bendichter
Copy link
Contributor

As far as looking stale, I think the commit history tells the story. I'd rather not modify the dates to be a range. While a single date can indicate the start, if we use a range then the package really will be out of date on Jan 1 2025

@yarikoptic
Copy link
Contributor Author

nobody looks at commit history while going through documentation

looking at documentation and seeing 2022 doesn't tell me that the project is that old, it tells me that it is possibly no longer developed . I will not jump to github to verify etc.

It is very easy to update once a year

I had similar discussions for dandi-archive I believe.

But of cause it is just my 1c, the tool is yours... but forgetful me might suggest the same later ;-)

@CodyCBakerPhD
Copy link
Collaborator

@CodyCBakerPhD
Copy link
Collaborator

Thoughts @stephprince ?

@stephprince
Copy link
Contributor

stephprince commented Aug 8, 2024

I am good with updating the dates to be a range. In pynwb it's part of the release template checklist to update the dates which is helpful. I don't think there's a similar checklist here, but I think for a once-a-year update that's fine to remember.

@yarikoptic
Copy link
Contributor Author

@CodyCBakerPhD how more could I be of help? ;)

@CodyCBakerPhD
Copy link
Collaborator

@yarikoptic Steph is willing to take care of this so it is in their hands now. Likely hear back from them in next 48 hours

Copy link
Contributor

@stephprince stephprince left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added the copyright year range to the license as well. I think the docs/conf.py and license.txt are the only two places that need to be updated each year.

Otherwise looks good to me!

@stephprince stephprince merged commit 6fc57e5 into NeurodataWithoutBorders:dev Aug 12, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants