-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add check for missing timezone. #458
base: dev
Are you sure you want to change the base?
Conversation
for more information, see https://pre-commit.ci
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #458 +/- ##
==========================================
+ Coverage 86.78% 86.91% +0.12%
==========================================
Files 23 23
Lines 1241 1253 +12
==========================================
+ Hits 1077 1089 +12
Misses 164 164
Flags with carried forward coverage won't be shown. Click here to find out more.
|
It looks like this is (edit: were) failing because there is a workflow that explicitly tests older versions of pynwb and this fails in that case since the feature is only supported in 2.7.0+. What should we do here? Here are some options:
|
Another question about this is how this would be integrated with NWB GUIDE. Does the GUIDE have a way to enter timezones yet? If not, we are setting users up for a best practice warning they are not able to address. |
Yeah this has been a long-time question about how the Inspector should interact with PyNWB versions in general (in addition to cached schema within each file??): #263 Posted your ideas on that thread Skipping per test is fine for now and has been the way forward for the time being |
It looks like it still automatically sets based on computer clock I think we were partially waiting on finding a better timestamp widget, but @garrettmflynn for the time being can you add a simple dropdown selector for |
Codespell:
Is codespell checking the spelling of code? How can we get it to skip this? |
Hah, looks like an issue for very recent versions of codespell - already some others have noticed: codespell-project/codespell#3430 Doing a local ignore now |
.github/workflows/codespell.yml
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also discovered that we added this to pre-commit at some point: https://github.com/NeurodataWithoutBorders/nwbinspector/pull/458/files#diff-63a9c44a44acf85fea213a857769990937107cf072831e1a26808cfde9d096b9L13
but didn't remove the GitHub action
More pressing issue is some rather strange |
@CodyCBakerPhD this is probably because import datetime
isinstance(datetime.datetime.now(), datetime.date)
|
It's true on Windows. Very odd |
Also add best practice docs and tests for check