Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MakeComment Metadata optional #326

Closed
Batwam opened this issue Jun 5, 2023 · 8 comments · Fixed by #335
Closed

MakeComment Metadata optional #326

Batwam opened this issue Jun 5, 2023 · 8 comments · Fixed by #335
Labels
feature New feature or request in-beta This issue is fixed in a beta version
Milestone

Comments

@Batwam
Copy link

Batwam commented Jun 5, 2023

Hello, when selecting "include metadata", the file is being "earmarked" by including a link to the original video in the "Comment" field. I was wondering if it would be possible to make this Comment metada optional?

I also think that it would be useful to include a subtitle to describe what medata is being embedded:
image

My suggestion would be to have "Include link to original file" as a separate Gtk.Switch and have a Subtitles in the current switch to explain that the medata embedded contains Audio and Video properties only.

@nlogozzo
Copy link
Member

nlogozzo commented Jun 5, 2023

This is all handled by yt-dlp. If active, the Embed Metadata switch just tells yt-dlp to include metadata. What metadata in included and where, is all determined by yt-dlp and changes between websites, meaning we can't really control it.

@nlogozzo nlogozzo closed this as not planned Won't fix, can't repro, duplicate, stale Jun 5, 2023
@Batwam
Copy link
Author

Batwam commented Jun 5, 2023

Having just had a look at yt-dlp, it does appear to include a section on tailored metadata with the following example:

# Set "comment" field in video metadata using description instead of webpage_url,
# handling multiple lines correctly
$ yt-dlp --parse-metadata "description:(?s)(?P<meta_comment>.+)" --embed-metadata

So, it looks like there might already a built-in option to include something else than the url in the Comment section, which could also be used to leave the comment blank if needed?

@nlogozzo
Copy link
Member

nlogozzo commented Jun 5, 2023

@fsobolev thoughts?

@fsobolev
Copy link
Member

fsobolev commented Jun 5, 2023

I will figure out how to overwrite metadata.

@fsobolev fsobolev reopened this Jun 5, 2023
@fsobolev fsobolev added the feature New feature or request label Jun 5, 2023
@fsobolev fsobolev added this to the V2023.6.1 milestone Jun 5, 2023
@fsobolev
Copy link
Member

fsobolev commented Jun 5, 2023

A note from Matrix chat:

By the way, having looked through the files using exiftool yt-dlp also appears to copy original data (the video Description) in the “Description” and “Long Description” Exif fields…

@nlogozzo nlogozzo added the in-beta This issue is fixed in a beta version label Jun 10, 2023
@nlogozzo
Copy link
Member

@Batwam
Copy link
Author

Batwam commented Jun 10, 2023

Hi, I just tried the files generated using the new version using exiftool and the url still appears under the "User Defined Text" field. same thing for for Audio and Video.

@nlogozzo
Copy link
Member

I'll fix that...looks like we have to clear the "purl" field as well

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request in-beta This issue is fixed in a beta version
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants