Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shell Notification Button To Open File #668

Merged
merged 8 commits into from
Nov 16, 2023
Merged

Shell Notification Button To Open File #668

merged 8 commits into from
Nov 16, 2023

Conversation

nlogozzo
Copy link
Member

Closes #666

@nlogozzo nlogozzo marked this pull request as ready for review November 16, 2023 17:21
@nlogozzo
Copy link
Member Author

Hi @Jummit , could you test this build for me?

https://github.com/NickvisionApps/Parabolic/actions/runs/6894237652

Go to the artifacts section and download the flatpak zip. From there install and run the .flatpak file with these commands:

flatpak install org.nickvision.tubeconverter.flatpak
flatpak run org.nickvision.tubeconverter//master

From there you can download a video and then deactivate the window (click off of it or minimize it) to trigger the shell notification when the download finishes, as always.
The notification should now have an Open File button to launch the file when clicked.

Let me know how it goes (I currently develop everything on Windows/WSL, and since I don't have an actual GNOME desktop I can't test the shell notification myself). Once you are done testing you can uninstall the build with:

flatpak uninstall org.nickvision.tubeconverter//master

Copy link
Member

@DaPigGuy DaPigGuy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM & tested on GNOME 45

@nlogozzo nlogozzo merged commit 19948cb into main Nov 16, 2023
@nlogozzo nlogozzo deleted the shell branch November 16, 2023 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request] Add play button to notification when download finished
2 participants