Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pill10 #216

Merged
merged 3 commits into from
Jul 10, 2023
Merged

Pill10 #216

merged 3 commits into from
Jul 10, 2023

Conversation

henrik-ch
Copy link
Contributor

@henrik-ch henrik-ch commented Jun 6, 2023

Small update - this update should follow pill 8 update if/when we are happy with that one.

removed and reduced use of with.
updated tarball version and small change to indentation.
@henrik-ch henrik-ch self-assigned this Jun 6, 2023
Copy link
Contributor

@fricklerhandwerk fricklerhandwerk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unless some fairly uncontroversial formatted changed indentation I'd keep it, otherwise good :)

pills/10/hello-nix.txt Show resolved Hide resolved
@henrik-ch henrik-ch marked this pull request as ready for review June 29, 2023 13:00
@proofconstruction proofconstruction removed the request for review from jtojnar July 10, 2023 17:21
@proofconstruction
Copy link
Contributor

Discussed in Documentation Team meeting. Looks good to me. Glad to see some love for Nix Pills again!

@proofconstruction proofconstruction merged commit ea8ef42 into NixOS:master Jul 10, 2023
1 check passed
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/2023-07-10-documentation-team-meeting-notes-62/30291/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

4 participants