Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solve a discrepancy in pill 7.7 #222

Merged
merged 1 commit into from
Oct 18, 2023
Merged

Conversation

MathiasMalandain
Copy link
Contributor

Related issue

Closes #221

Notes

Two choices were made:

  • explaining that derivations coming from <nixpkgs> have to be referred to as members of the set assigned to local variable pkgs;
  • skipping any explanation about the use of the with keyword, although it would be the one-to-one equivalent of what was done in the REPL.

Edits allowed.

Solve the discrepancy between the code and its description
Copy link
Contributor

@drupol drupol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

I'll let @fricklerhandwerk review/merge this too.

@MathiasMalandain
Copy link
Contributor Author

FYI: If this PR is fine with you, I will probably spend some time this week to update pill 8.3 in a similar fashion (it is still written as if with statements were used). Very same process: issue, fork, PR, so that you keep track of everything.

@drupol
Copy link
Contributor

drupol commented Oct 17, 2023

We are super happy to receive contributions for documentation, so please keep them coming :)

@drupol drupol merged commit 17da99f into NixOS:master Oct 18, 2023
1 check passed
Comment on lines +304 to +305
<varname>pkgs</varname> and brings it into scope. This has an effect similar to
the <command>:l &lt;nixpkgs&gt;</command> we used in <application>nix repl</application>,
Copy link
Member

@jtojnar jtojnar Apr 9, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the :l mention only makes sense as a reference to with, since both bring the attributes inside pkgs into the scope.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Small discrepancy in pill 7.7
3 participants