Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix link to functions manual #247

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

andriyun
Copy link

@andriyun andriyun commented May 29, 2024

There is an incorrect URL to the functions manual on page https://nixos.org/guides/nix-pills/05-functions-and-imports

image

This PR fixes it

Copy link
Contributor

@drupol drupol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The original link leads to a 404, the second link works as expected.

@@ -2,7 +2,7 @@

Welcome to the fifth Nix pill. In the previous [fourth pill](04-basics-of-language.md) we touched the Nix language for a moment. We introduced basic types and values of the Nix language, and basic expressions such as `if`, `with` and `let`. I invite you to re-read about these expressions and play with them in the repl.

Functions help to build reusable components in a big repository like [nixpkgs](https://github.com/NixOS/nixpkgs/). The Nix manual has a [great explanation of functions](https://nixos.org/manual/nix/stable/expressions/language-constructs.html#functions). Let's go: pill on one hand, Nix manual on the other hand.
Functions help to build reusable components in a big repository like [nixpkgs](https://github.com/NixOS/nixpkgs/). The Nix manual has a [great explanation of functions](https://nix.dev/tutorials/nix-language.html#functions). Let's go: pill on one hand, Nix manual on the other hand.
Copy link
Member

@jtojnar jtojnar May 29, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like the correct address is https://nix.dev/manual/nix/latest/language/constructs#functions now. But it really is a bug in nixos-homepage NixOS/nixos-homepage#1452

@SuperSandro2000
Copy link
Member

Yes, this will probably be fixed shortly. Don't change the links yet.

@jtojnar jtojnar marked this pull request as draft May 29, 2024 07:42
@andriyun
Copy link
Author

The redirect works fine for me. I've updated the link to https://nix.dev/manual/nix/latest/language/constructs#functions

@jtojnar jtojnar marked this pull request as ready for review May 29, 2024 09:05
@andriyun
Copy link
Author

andriyun commented Jun 6, 2024

Hey @SuperSandro2000

Is there anything I can do for this PR? :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

None yet

4 participants