-
-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RFC 166 implementation tracking issue #153
Comments
Proposal: do reformatting in the NixOS org with a few non-nixpkgs repos first |
Proposal: After what @tomberek suggested is done and successful, do formatting of Nixpkgs in a subset of Nixpkgs first (i.e. |
https://github.com/Kreyren/nixos-config/blob/dc0dbb6f15c4d8656b26220645793a06d10fa3ea/nixos/users/kreyren/home/modules/prompts/starship/starship.nix#L3-L14 (best seen in raw) RFC @infinisil Is this known issue that is actionable by RFC166? I read through it don't see it anywhere (if tabs are used it causes the prompt to be rendered with long indentation instead of the indentation being removed from the declaration, affects most of nix modules) |
This looks unlikely to be a desired output according to the RFC format. Now that the PR is merged, please simply open an issue for it. |
As [established by RFC 166](https://github.com/NixOS/rfcs/blob/master/rfcs/0166-nix-formatting.md#nix-formatter-team), see also NixOS/nixfmt#153. Before merging I'd like all members to give their okay with their entry. Ping @NixOS/nix-formatting --------- Co-authored-by: Sereja313 <[email protected]>
This issue has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/formatting-team-meeting-2024-03-19/41845/1 |
Referencing comment by @roberth in NixOS/nix#8874 (comment) Got referred to RFC166 from RFC137 about this issue in relation to addressing NixOS/nix#8874 |
@Kreyren please just open a new issue with input, current output and desired output and I'll look at it. Simply linking to weird looking code does not give me enough context to understand the situation. |
This issue has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/tweag-nix-dev-update-56/43035/1 |
This issue has been mentioned on NixOS Discourse. There might be relevant details there: |
Currently using alejandra for now, this isn't needed fixes the following warning: trace: warning: nixfmt was renamed to nixfmt-classic. The nixfmt attribute may be used for the new RFC 166-style formatter in the future, which is currently available as nixfmt-rfc-style More details in: NixOS/nixfmt#153
This issue has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/enforcing-nix-formatting-in-nixpkgs/49506/3 |
This issue has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/enforcing-nix-formatting-in-nixpkgs/49506/8 |
This issue has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/satisfaction-survey-from-the-new-rfc-166-formatting/49758/1 |
This issue has been mentioned on NixOS Discourse. There might be relevant details there: |
@infinisil et. al.: ❤️ Thanks a lot for pushing this and the hard work on it! I am happy if that debate is soon over =) and we have some opiniated way to not disgress again and again into whitespace debates in PRs. Having a 90% solution is so much better then having nothing which puts Nixpkgs back to middleages. |
nixpkgs-fmt was archived[1] in favour of nixfmt[2], which implements the Nix RFC 166[3]. See NixOS/nixfmt#153 for further details about the progress of the implementation. [1]: https://x.com/zimbatm/status/1816148339131343058 [2]: https://github.com/NixOS/nixfmt?tab=readme-ov-file#readme [3]: https://github.com/nix-rfc-101/rfcs/blob/aaf1613f/rfcs/0166-nix-formatting.md
nixpkgs-fmt was archived[1] in favour of nixfmt[2], which implements the Nix RFC 166[3]. See NixOS/nixfmt#153 for further details about the progress of the implementation. [1]: https://x.com/zimbatm/status/1816148339131343058 [2]: https://github.com/NixOS/nixfmt?tab=readme-ov-file#readme [3]: https://github.com/nix-rfc-101/rfcs/blob/aaf1613f/rfcs/0166-nix-formatting.md
nixpkgs-fmt was archived[1] in favour of nixfmt[2], which implements the Nix RFC 166[3]. See NixOS/nixfmt#153 for further details about the progress of the implementation. [1]: https://x.com/zimbatm/status/1816148339131343058 [2]: https://github.com/NixOS/nixfmt?tab=readme-ov-file#readme [3]: https://github.com/nix-rfc-101/rfcs/blob/aaf1613f/rfcs/0166-nix-formatting.md
nixpkgs-fmt was archived[1] in favour of nixfmt[2], which implements the Nix RFC 166[3]. See NixOS/nixfmt#153 for further details about the progress of the implementation. [1]: https://x.com/zimbatm/status/1816148339131343058 [2]: https://github.com/NixOS/nixfmt?tab=readme-ov-file#readme [3]: https://github.com/nix-rfc-101/rfcs/blob/aaf1613f/rfcs/0166-nix-formatting.md
nixpkgs-fmt was archived[1] in favour of nixfmt[2], which implements the Nix RFC 166[3]. See NixOS/nixfmt#153 for further details about the progress of the implementation. [1]: https://x.com/zimbatm/status/1816148339131343058 [2]: https://github.com/NixOS/nixfmt?tab=readme-ov-file#readme [3]: https://github.com/nix-rfc-101/rfcs/blob/aaf1613f/rfcs/0166-nix-formatting.md
Now that RFC 166 is accepted, let's commence with the implementation!
Here's a very rough todo-list, most of which will be fairly quick.
Create a GitHub project boardLet's only start using one if we feel the need for it
nix fmt
to point tonixfmt
: WIP: feat(fmt): use nixfmt-rfc-style nix#11252Ping @piegamesde @tomberek @0x4A6F @Sereja313 @dasJ
The text was updated successfully, but these errors were encountered: