Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple hyperlinks redirecting to invalid URLs on nixos.org/learn #1448

Closed
1 task
dpeachpeach opened this issue May 27, 2024 · 3 comments · Fixed by #1451
Closed
1 task

Multiple hyperlinks redirecting to invalid URLs on nixos.org/learn #1448

dpeachpeach opened this issue May 27, 2024 · 3 comments · Fixed by #1451
Labels

Comments

@dpeachpeach
Copy link

Introduce your stance
A number of hyperlinks on the nixos.org website seem to be redirecting incorrectly. I saw that there was a PR that was merged that was supposed to solve this in #1447, but it seems like there still is a problem.

Describe the issue
Multiple links on this page:
https://nixos.org/learn/

Such as all of the ones in this screenshot:
Screenshot 2024-05-26 at 7 35 13 PM

Direct to links such as:
https://nix.dev/manual/nix/2.18/stable/installation/installing-binary. Which returns a page not found error:
Screenshot 2024-05-26 at 7 36 00 PM

When the 'functional' link seems to be:
https://nix.dev/manual/nix/2.18/installation/installing-binary

Page links

Additional context
I know that nix.dev is separate from this website, so I'm not sure where the burden of 'improvement' falls under. However, these links are still broken and I just wanted to alert someone. I could start up a PR to fix this pretty quickly as well if I required but I just wanted to confirm that this wasn't fixed. Thank you!

  • I already created a Pull Request
@fricklerhandwerk
Copy link
Contributor

Thanks for reporting, I'll take care of it.

@proofconstruction
Copy link

Some context since I've also been hunting for the appropriate fix here:

All of those links are under https://nixos.org/learn/manual/nix/stable which is redirected by

[[redirects]]
from = "/manual/nix/*"
to = "https://nix.dev/manual/nix/stable/:splat"
to https://nix.dev/manual/nix/stable/stable.

The first stable gets transformed into the current stable numeric version by mutableRedirect during the nix.dev installPhase; this transformation is reified as a netlify redirect during the CI workflow. The resulting link 404s, as <version>/stable is not a valid path.

This is yet more reason to unify the docs-related infrastructure across repositories; see #1141 for earlier discussion.

thilobillerbeck pushed a commit that referenced this issue May 28, 2024
1f1fbfc and
5f00e55 were a confused about old and
new URL formats, and it didn't help that very similar-looking redirects
were in multiple locations of the file.

this change brings them together and should restore all existing URLs
and correctly point them to nix.dev.

closes #1448 - sorry everyone for the disruption, and thanks again for
pointing out the breakages. ping me directly if anything else around the
Nix manual falls apart.
@nixos-discourse
Copy link

This issue has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/2024-05-31-documentation-team-meeting-notes-130/46261/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants