Add editorconfig #13
Merged
Add editorconfig #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We could also add CI to check that, but I don't think it's that important. I think it's just good practice for all repos to have one of those :) |
philiptaron
reviewed
Mar 19, 2024
Comment on lines
+10
to
+12
| [*.rs] | ||
| indent_size = 4 |
There was a problem hiding this comment.
I like adding max_line_length = 100 (maybe for all)
I would also like to use the nixfmt-rfc-style nix formatter!
https://github.com/rust-lang/rust/blob/master/.editorconfig
There was a problem hiding this comment.
Let's do Nix formatting with another PR, but the max line length sounds good, added it for [*] :)
philiptaron
approved these changes
Mar 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://editorconfig.org/