Refactor Error Types #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It can be derived from the package_name
to avoid confusing it with a valid package_name where relative_package_dir could be derived.
Fix clippy warning about same postfix "Problem" in struct names on NixpkgsProblem enum
|
I'm not able to add reviewers @infinisil @philiptaron :) |
philiptaron
reviewed
Mar 25, 2024
infinisil
requested changes
Mar 25, 2024
There was a problem hiding this comment.
Reviewed together in today's office hour with @willbush and @philiptaron
Got some minor suggestions, overall looking good.
One other thing is to add simple comments to the new types.
To remove duplicate `.into()` calls
infinisil
approved these changes
Mar 26, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work related to: #2
This pull request does not change the single-line vs multi-line style or any of the error messages. The goal here is to reduce code duplication.
A lot of the NixpkgsProblem enum variants had common fields more or less due to the context of where the error originated.
I grouped these similar problems into structs which contains the common fields and a
kindenum to differentiate between the different types of problems.