Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create a Nixpkgs PR after releases #37

Merged
merged 1 commit into from
Apr 10, 2024
Merged

Create a Nixpkgs PR after releases #37

merged 1 commit into from
Apr 10, 2024

Conversation

infinisil
Copy link
Member

This should fix #29

This work is sponsored by Antithesis ✨

@infinisil infinisil force-pushed the automated-release-prs branch 4 times, most recently from 240ec35 to de5c6d0 Compare April 9, 2024 19:53
@infinisil
Copy link
Member Author

infinisil commented Apr 9, 2024 •
edited
Loading

Basic tests indicate it works: tweag/nixpkgs#90 :D

We are missing a changelog from our releases, but that could be done another time. Edit: Now wrote some thoughts down for that in #38

@infinisil infinisil mentioned this pull request Apr 9, 2024
Open
@willbush
Copy link
Member

willbush commented Apr 9, 2024

We are missing a changelog from our releases

@infinisil Something to consider: https://git-cliff.org/
I've never gotten around to trying it personally

@infinisil infinisil changed the title Create a Nixpkgs PR after releases [WIP] Create a Nixpkgs PR after releases Apr 9, 2024
@infinisil infinisil marked this pull request as ready for review April 9, 2024 23:20
@infinisil infinisil requested a review from a team as a code owner April 9, 2024 23:20
@infinisil
Copy link
Member Author

@willbush Let's discuss that in #38 :)

@infinisil
Copy link
Member Author

After testing it in tweag/nixpkgs#90, I just moved it from the PR-triggered workflow file to the release-triggered one (diff) (and added the needs: release and changed it to the NixOS/nixpkgs repo), so in theory it should work when this PR gets merged :)

willbush
willbush approved these changes Apr 10, 2024
View reviewed changes
Copy link
Member

@willbush willbush left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

philiptaron
philiptaron approved these changes Apr 10, 2024
View reviewed changes
Copy link
Contributor

@philiptaron philiptaron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's so cool that a completely separate repository can initiate PRs to nixpkgs.

@philiptaron philiptaron merged commit 44d5e2e into main Apr 10, 2024
1 check passed
@philiptaron philiptaron deleted the automated-release-prs branch April 10, 2024 15:10
@infinisil
Copy link
Member Author

Nice, it worked: NixOS/nixpkgs#303140

Need to fix CODEOWNERS for me to get a ping though :) NixOS/nixpkgs#303141

@philiptaron
Copy link
Contributor

The codeowners file has errors:

image

@infinisil
Copy link
Member Author

Not directly related, but feel free to fix it :)

@philiptaron
Copy link
Contributor

Can I? https://github.com/orgs/NixOS/teams/qt-kde appears to exist; what's wrong?

@infinisil
Copy link
Member Author

I'm guessing the "has write access to the repository" part

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@philiptaron philiptaron philiptaron approved these changes

@willbush willbush willbush approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Automatically create a Nixpkgs PR when a new release is published
3 participants
@infinisil @willbush @philiptaron