Safer releases #48
Merged
Safer releases #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This prevents releasing if a merge commit doesn't pass CI. This can happen as such: - Two PRs get opened, CI runs successfully against the current base branch for both - Both get merged, both of them combined would fail CI though
By default the target_commitish would be the _latest_ commit on the default branch, which could change underneath us
No need to have this many steps
willbush
approved these changes
Apr 18, 2024
Merged
I didn't like how it would print for all PRs unnecessarily Furthermore it's cleaner if we trigger it based on when a release is published, instead of depending the build job
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes it so that a release only happens if CI succeeds