Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace from_utf8 with more lenient from_utf8_lossy #59

Merged
merged 1 commit into from
Apr 29, 2024

Conversation

willbush
Copy link
Member

Noticed we're not using lossy version of from_utf8 in one place, but we are in two other places:

src/eval.rs
178                  String::from_utf8_lossy(&result.stdout)

src/main.rs
276          let actual_errors = String::from_utf8_lossy(&writer).replace(&expr_path, "src/eval.nix");

@willbush willbush requested a review from a team as a code owner April 29, 2024 01:39
Copy link
Member

@infinisil infinisil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@infinisil infinisil merged commit b14e81b into NixOS:main Apr 29, 2024
3 checks passed
@willbush willbush deleted the lossy-utf8 branch April 29, 2024 03:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants