-
-
Notifications
You must be signed in to change notification settings - Fork 13.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
'-fno-strict-overflow'-warnings litter certain builds on darwin #39687
Comments
strictoverflow
hardening in clangStdenvstrictoverflow
hardening in clangStdenv (e.g. darwin)
Hm. It seems the flag should actually be accepted by clang. I don't know why these warnings keep turning up though. |
strictoverflow
hardening in clangStdenv (e.g. darwin)
It says unused, not unsupported. I think it can happen, for example, when using clang to with assembly files and such? |
Yes, this is mostly cosmetic, I just had a look at the current Cython darwin build (in #39576), which sports an impressive number of 1828 of those warnings: https://nix-cache.s3.amazonaws.com/log/x9ff903kpnmmvf39cdw4pbp08rl30mmh-python3.6-Cython-0.28.1.drv |
LOL that is a lot. It is definitely not just Nixpkgs that is doing this though (jedisct1/libsodium#201). We can definitely set |
This is breaking packages that use |
To future readers, this is the solution:
|
On darwin the compilation would fail with the following warning: ``` clang-7: error: argument unused during compilation: '-fno-strict-overflow' [-Werror,-Wunused-command-line-argument] ``` This error happens because the `-fno-strict-overflow` is passed to the compiler. To fix this, disable the `strictoverflow` hardening feature. Also see NixOS#39687. ZHF: NixOS#97479
On darwin the compilation would fail with the following warning: ``` clang-7: error: argument unused during compilation: '-fno-strict-overflow' [-Werror,-Wunused-command-line-argument] ``` This error happens because the `-fno-strict-overflow` is passed to the compiler. To fix this, disable the `strictoverflow` hardening feature. Also see #39687. ZHF: #97479
I marked this as stale due to inactivity. → More info |
Support for newer versions of GCC was added in 0.6.4 https://numcodecs.readthedocs.io/en/stable/release.html#release-0-6-4 Also disable `strictoverflow` during hardening. Ref NixOS#39687
Should be solved generally now, via PR #243595 |
Issue description
When building C++ on darwin, oftentimes the following warning litters the logs:
The text was updated successfully, but these errors were encountered: