-
-
Notifications
You must be signed in to change notification settings - Fork 13.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[staging-20.09] Add ghc8102BinaryMinimal to stay within hydra limits on aarch64 #102504
[staging-20.09] Add ghc8102BinaryMinimal to stay within hydra limits on aarch64 #102504
Conversation
I wanted to build this locally but it does not eval. Tried it on x86_64-linux |
@SuperSandro2000 fixed in |
6b80eb8
to
95b230c
Compare
95b230c
to
a945a85
Compare
I've
Presumably hydra will still allow it to be built for use as a dependency. Thanks @cole-h. I suppose ofborg was failing in the comparison step because the old version was bad, so it seems like ofborg should work now 🎉 |
I suspect it will get into |
If hydra only pushes closures of attributes with non-nil |
|
We could switch to fixing |
I'm happy to add the forward port there, but I don't think we should delay this PR for it. |
|
Why did you touch |
a945a85
to
22e9260
Compare
A mistake I didn't catch because I evaluated on |
Uh, I got some glitch
but it disappeared on retrying, so I expect I'll ignore it. |
It built successfully on my machine. |
|
Hydra (not this PRs base branch though!): https://hydra.nixos.org/eval/1624234 |
(this one was used for current nixpkgs master) |
I think the problem here is that we utilize |
Not distributing dependencies via hydraPlatforms does not work, so we keep meta simple.
Some good news. I had overlooked a class of profiling files, so I've added the docs back in and we're at only 74% of the limit now. |
✔️ tested |
Motivation for this change
Make ghc buildable on hydra for
aarch64
.It's currently failing with
Output limit exceeded
https://hydra.nixos.org/build/129487354#tabs-summaryHydra only allows outputs up to 231 NAR bytes.
The new
ghc8102BinaryMinimal
is 2136668000 out of 2147483648 bytes; ~10M under the limit.This is achieved by removing the documentation and the profiling objects, neither of which are used for bootstrapping.
I have a build of GHC 8.8.4 in that's in progress.
TODO
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)