-
-
Notifications
You must be signed in to change notification settings - Fork 13.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TEST: reformat all nix files with nixpkgs-fmt #121490
Conversation
Thanks for starting this. Let us know if you need some help or some build power to test something. |
The commit message for the main commit here is crucial documentation that can't be changed afterwards; it is therefore critical to get this right. I'd propose something like:
The info URL is so we can give more information in the future. |
I like the general idea of doing this. However, there are some things I don't like about the current formatting:
packageA, It was formatted to this: packageA The comments are really not great, the second thing is less of an issue, but I'd never manually format it like that. (This was just with a brief look, haven't looked very long at this) |
I agree it should leave comments alone. A good example is these docs:
the flattening here is unfortunate. |
That looks like nix-community/nixpkgs-fmt#243 |
I wanted to open this to test that whole nixpkgs/NixOS still evals. Unfortunately master moves quite fast and conflicts arise as soon as something is merged. Is there a way to run the whole eval suite locally? |
928b186
to
f5f8f24
Compare
Built nixpkgs-fmt from master and ran |
This still doesn't look quite right: But maybe that's intended, I'm not sure. It's not something I'd do by hand though. But overall this looks a lot better to me! |
Comma at the end of at the beginning is a debate I'd like to avoid here and what's important is that we can have either way as that is a lossless conversion. Other things anyone can notice? Otherwise it seems like nixpkgs-fmt formats all files and eval checks pass. I've also tested that running it twice doesn't make any new modifications 🍿 |
|
One auto-generated file looks like it is responsible for the majority of the diff in this PR.
|
This would look better IMO: {
foo
# comments about bar
, bar
} I think it would be valid too? Not sure how feasible or easy though. |
I marked this as stale due to inactivity. → More info |
DO NOT MERGE
Testing #120832 with: