-
-
Notifications
You must be signed in to change notification settings - Fork 13.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
stdenv/mkDerivation: derive pname and version when not given #124520
stdenv/mkDerivation: derive pname and version when not given #124520
Conversation
823e796
to
07667b9
Compare
07667b9
to
ab64e0c
Compare
This shouldn't break anything, unless anyone is explicitly depending on |
I am keen on seeing the evaluation performance report in the Checks tab for this change. |
It sounds problematic for the same reason as #68620 (comment). |
Yeah, I was thinking about adding a check to ensure that |
Plexamp doesn't have a version attribute because the builder we use doesn't support that. Until NixOS/nixpkgs#124520 is merged, we have to use a bit of a workaround.
actually this is pretty cool!
we could also hunt down those occurrences (in nixpkgs), by adding a trace |
I marked this as stale due to inactivity. → More info |
Hi @Synthetica9, I'm cherry-picking abandoned PR in Do you think you could give it a refresh so we can move forward? If not, feel free to close the PR. Thanks in advance. |
Another reason this can be problematic is that with the current convention for unstable versions, it can split it improperly – not that there are many such packages (16 according to But I would rather just treat |
We're moving away from setting name #103997 so i don't see a need for this PR |
Motivation for this change
Add
pname
andversion
to all packages automatically when not already given.Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)