-
-
Notifications
You must be signed in to change notification settings - Fork 13.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
qt4: remove #174634
qt4: remove #174634
Conversation
3217fa3
to
a47ada4
Compare
@GrahamcOfBorg eval |
Qt4 has been EOL since the end of 2015 and a lot of distributions removed it years ago (e.g. Ubuntu 20.04). #33248 was opened in 2017. I tried to update what I could, but these aren't my packages, so this will still end up removing a few dozen packages. I'm notifying you, because you are listed as maintainer for one or more of these packages.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am fine with the removal of valkyrie. The last release was on 21 October 2010.
If applications are still otherwise working, I see no reason to drop them (and as a consequence no reason to drop qt4). We still carry applications that use GTK2 as an example. |
GTK2 reached it's end of life roughly 4 years after QT4: https://blog.gtk.org/2020/12/16/gtk-4-0/ "applications are still working" is always debatable. python2 "stilI works", as well, but it's unsupported, libraries aren't remaining compatible and it's most likely a security hazard. IMO this is mainly about maintainability and trying to have software, especially something as large and integral as a framework like QT, in our repository where there is an upstream that at least tries to support and maintain it. Nobody is stopping anyone from having a flake or maintaining these things out of tree, which is why I think something like https://github.com/fossar/nix-phps is a commendable project, but having these things in nixpkgs creates the illusion of being able to support them in an official capacity. Which we are 100% not able to. |
Regarding |
Agreed, this is what other systems like OpenBSD have done as well: |
Exactly. Keeping unmaintained frameworks/languages/etc. around is a huge burden. Transitions to newer versions, e.g. Python 2 to 3 or Qt 4 to 5, are a huge ordeal already as they practically always cause waves of new issues for both maintainers and users. Beating dead horses like Python 2, Qt 4, etc. just keeps adding overhead. |
This reverts commit c8db82b.
This reverts commit 2c78308.
This reverts commit 7727bef.
This reverts commit 422f1c2.
This reverts commit e600ef0.
This reverts commit fd3646f.
This reverts commit d7ea3d7.
depends on qt4
Current python version is 3.10 Makefile:22: *** You must have at least 3.5 installed. Stop.
I think it would be nice if we could get this in, before RFC140 is fully implemented. |
This appears to have broken
|
NixOS#174634 removed qt4 but enabled the (previosly disabled) qt5, breaking the build. Disable QT5 again by disabling qt all together.
NixOS#174634 removed qt4 but enabled the (previosly disabled) qt5, breaking the build. Disable qt5 again by disabling qt all together.
Description of changes
qt4 has been EOL since the end of 2015. A look at a calendar tells us it is 2023 now.
Closes #33248
Still WIP. I'm trying to fix/update what I can, but if packages are dead upstream or updates non-trivial and maintainers don't respond, packages will be removed.
Things done
sandbox = true
set innix.conf
? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)nixos/doc/manual/md-to-db.sh
to update generated release notes