-
-
Notifications
You must be signed in to change notification settings - Fork 13.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
nixos/doc: clean up the kernel building section a bit #178565
Conversation
- suggest overriding the existing kernel before using a fully custom config - use consistent context (no `super`, just `pkgs`) everywhere - replace `mptcp93` (long removed) in examples with a recent-ish kernel - explain how to actually use the kernel in your config - remove the awkward "make menuconfig" incantation (needs way more context than what's provided)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, much clearer than before ✨
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i like the changes.
it helped me to figure out what i did wrong when trying to build my own kernel config whilst getting not understandable nix errors as there was no real example available what really is needed.
i have an additional question/point. my main approval was that its more clear what to do and how to actually link the kernel with the system (
That actually gives me:
whilst just
prints
edit: i noticed, that i cannot randomly override modDirVersion, but i think that its still an issue as my custom config is also not explorable via nix repl. which looks for me that overriding needs to be passed via Could you please cross check it? Would be glad if the documented way actually works. |
Gonna draft this for now until I can sit down and double-check everything. |
Revived this in #207095, along with some other minor simplifications.
Each kernel version calls |
Description of changes
super
, justpkgs
) everywheremptcp93
(long removed) in examples with a recent-ish kernelFixes-ish #178476.
Things done
sandbox = true
set innix.conf
? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)nixos/doc/manual/md-to-db.sh
to update generated release notes