-
-
Notifications
You must be signed in to change notification settings - Fork 13.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
stdenv: Allow exceptions to blocklisted-licenses to be specified #178891
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me and seems like a sensible thing but It might make sense to add a nixos test for this.
Ok, I will look into doing that over the next couple of days. Thanks |
Given that NixOS/rfcs#127 is on the brink of being merged, I'd like to postpone any additional complexity to the current ignore infrastructure until it after RFC 127 has been implemented. |
@piegamesde what would you suggest are the next steps here now since rfc127 got merged? |
I'm working on the implementation of the RFC at the moment, but it's going to take a bit of time still |
I'm currently looking for alternatives to using predicates as I really dislike them, you may have some opinions on this: https://discourse.nixos.org/t/whats-the-use-case-for-allowunfreepredicate-and-friends/30468 |
Description of changes
This patch would allow the workflow of allowing, for example, GPL-licensed software in my nixpkgs configuration on a case-by-case basis the same way it's done for unfree packages.
Things done
sandbox = true
set innix.conf
? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)nixos/doc/manual/md-to-db.sh
to update generated release notes