Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stdenv: Allow exceptions to blocklisted-licenses to be specified #178891

Merged
merged 0 commits into from
Jun 11, 2024

Conversation

iptq
Copy link

@iptq iptq commented Jun 24, 2022

Description of changes

This patch would allow the workflow of allowing, for example, GPL-licensed software in my nixpkgs configuration on a case-by-case basis the same way it's done for unfree packages.

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.11 Release Notes (or backporting 22.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@github-actions github-actions bot added the 6.topic: stdenv Standard environment label Jun 24, 2022
@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jan 7, 2023
@stale stale bot removed the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jun 12, 2023
@Janik-Haag Janik-Haag changed the title stdenv: Allow exceptions to blocklisted licenses to be specified stdenv: Allow exceptions to blocklisted-licenses to be specified Jun 29, 2023
Copy link
Member

@Janik-Haag Janik-Haag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me and seems like a sensible thing but It might make sense to add a nixos test for this.

@iptq
Copy link
Author

iptq commented Jun 29, 2023

Ok, I will look into doing that over the next couple of days. Thanks

@piegamesde
Copy link
Member

Given that NixOS/rfcs#127 is on the brink of being merged, I'd like to postpone any additional complexity to the current ignore infrastructure until it after RFC 127 has been implemented.

@Janik-Haag
Copy link
Member

@piegamesde what would you suggest are the next steps here now since rfc127 got merged?

@piegamesde
Copy link
Member

piegamesde commented Jul 13, 2023

I'm working on the implementation of the RFC at the moment, but it's going to take a bit of time still

@piegamesde
Copy link
Member

I'm currently looking for alternatives to using predicates as I really dislike them, you may have some opinions on this: https://discourse.nixos.org/t/whats-the-use-case-for-allowunfreepredicate-and-friends/30468

@wegank wegank added 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md 2.status: merge conflict labels Mar 19, 2024
@stale stale bot removed the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Mar 20, 2024
@iptq iptq closed this Jun 11, 2024
@Lassulus Lassulus merged commit 8d7a677 into NixOS:master Jun 11, 2024
4 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants