openldap: do strip, with proper fix #18132
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@layus, thanks for your PR! By analyzing the annotation information on this pull request, we identified @rickynils, @lethalman and @edolstra to be potential reviewers |
layus
force-pushed
the
openldap-do-strip
branch
from
e165da2
to
136b4cf
Compare
|
Now, there may be a better fix than this one. The issue resides with the rpath of the executables containing the build path as their first element. When shrinking, that element is kept and the expected /nix/store location removed. I like this solution as it is very straightforward :-). |
|
The proper fix would be NixOS/patchelf#98. But that is too late for 16.09, so this is a nice solution for the time being. I will merge this along with #17916 tomorrow (since they rebuild roughly the same stuff). |
|
Merged, thanks. |
dezgeg
referenced
this pull request
Sep 1, 2016
The problem here was that the openldap binaries had /tmp/... in their RPATH *before* $out/lib, so patchelf --shrink-rpath considered the $out/lib entry unused. As a workaround, use NIX_LDFLAGS_BEFORE to ensure a proper order.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a proper fix of the build to work with elf stripping.
See 366c1e8 for some insight on the issue.