vlc: add aarch64-darwin and x86_64-darwin to platforms

[willemml]

Description of changes

Adds a darwin version of VLC.

Files formatted with nixfmt.

nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD" fails because it cannot find ibtool which is bundled with Xcode (it isn't a nix package, but it is on my system even though nix-shell doesn't find it.)

I did not add myself to the maintainers list.

Things done

• Built on platform(s)
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
• Tested, as applicable:
  • NixOS test(s) (look inside nixos/tests)
  • and/or package tests
  • or, for functions and "core" functionality, tests in lib/tests or pkgs/test
  • made sure NixOS tests are linked to the relevant packages
• Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
• Tested basic functionality of all binary files (usually in ./result/bin/)
• 23.05 Release Notes (or backporting 22.11 Release notes)
  • (Package updates) Added a release notes entry if the change is major or breaking
  • (Module updates) Added a release notes entry if the change is significant
  • (Module addition) Added a release notes entry if adding a new NixOS module
  • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
• Fits CONTRIBUTING.md.

[wegank]

I guess reformatting the files with nixfmt (at least for linux.nix) is not a good idea, as this would clearly mystify the patch. The maintainer of the package also seem to use nixpkgs-fmt instead.

[willemml]

I'll reformat it with nixpkgs-fmt, I thought nixfmt was the same thing.

[wegank]

The original default.nix has

  optionals skins2Support (with xorg; [
    freetype
    libXext
    libXinerama
    libXpm
  ])

so reformatting with nixfmt and then nixpkgs-fmt causes inconsistencies. I suggest leaving the original content untouched instead.

[wegank]

srcs and meta should be declared separately for the two derivations: otherwise, linux.nix would still be evaluable on darwin, and thus ibtool errors.

[willemml]

Do I have to declare the entirety of meta separately? Or can I declare it once and then append the platforms field?

I've now declared srcs separately and the platforms for meta (but not descriptions, and etc) separately but I still get the same ibtool error.

[wegank]

Oh, I checked the expressions in nixpkgs, and I think I'm wrong. Sorry for the inconvenience! It should be OK to inherit both of them. Let's see if ofborg evals.

[AndersonTorres]

This is ugly as hell.

First, it adds a binary-only package as if it was the same thing as a pure source.
Indeed, when I read the notification I thought "hey, they found some patch for building that pandemonium on Mac!". And what I found? A blob.

Second, it renames files without notice.

And third, I am far from being interested in keeping maintenance of a blob for a platform I have no access. Create something like vlc-bin = callPackage ../applications/video/vlc/bin.nix {}; and put your vlc-mac on it.

[willemml]

I realize now that binaries are undesirable, I'll just close this for now. Sorry for wasting the time of everyone who reviewed this.

[AndersonTorres]

Binaries are not undesirable per se. And, as an organization, NixOS/nixpkgs is not hostile to binary-only packages.

Sometimes binary-only packages are the only known option (nvidia blobs, boostrap compilers) or the source compilations is overly prohibitive (some Java packages).