Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cerebro: init at 0.11.0 #221238

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Conversation

kylesferrazza
Copy link
Member

Description of changes

Created the cerebro derivation.
Based on todoist-electron.

Closes #214977

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.05 Release Notes (or backporting 22.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Made sure it runs and is able to locate and run installed apps, and search the internet.

Copy link
Member

@dotlambda dotlambda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Specify meta.sourceProvenance.

@kylesferrazza
Copy link
Member Author

Specify meta.sourceProvenance.

Done

@erkkimon
Copy link

First of all, thanks @kylesferrazza for your contribution! Is there any blocker here? All checks have passed. We need Cerebro. :) ping @dotlambda

@wegank wegank added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Mar 19, 2024
@stale stale bot removed the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jun 29, 2024
Copy link
Member

@eclairevoyant eclairevoyant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution. There's some changes to be made below, as the packaging guidelines have changed since the original submission.

pkgs/applications/misc/cerebro/default.nix Outdated Show resolved Hide resolved
pkgs/applications/misc/cerebro/default.nix Outdated Show resolved Hide resolved
pkgs/applications/misc/cerebro/default.nix Outdated Show resolved Hide resolved
pkgs/applications/misc/cerebro/default.nix Outdated Show resolved Hide resolved
pkgs/applications/misc/cerebro/default.nix Outdated Show resolved Hide resolved
pkgs/top-level/all-packages.nix Outdated Show resolved Hide resolved
pkgs/applications/misc/cerebro/default.nix Outdated Show resolved Hide resolved
@wegank wegank added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jul 4, 2024
@stale stale bot removed the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Aug 25, 2024
@kylesferrazza kylesferrazza marked this pull request as draft August 25, 2024 17:19
@kylesferrazza
Copy link
Member Author

Addressed all the feedback, and all appears to go well, but unfortunately seeing a blank window when I launch the application. I'll need to keep investigating and push a fix. Converted to draft for now.

@kylesferrazza
Copy link
Member Author

Could be nvidia related...

$ ./result/bin/cerebro 

(electron:22952): Gtk-WARNING **: 13:22:27.639: Theme parsing error: gtk.css:9672:21: Not using units is deprecated. Assuming 'px'.
[22952:0825/132227.696167:ERROR:atom_cache.cc(229)] Add _NET_WM_WINDOW_TYPE_SPLASH to kAtomsToCache
DRM kernel driver 'nvidia-drm' in use. NVK requires nouveau.

@eclairevoyant

This comment was marked as resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cerebro launcher
6 participants