Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport release-23.05] [RFC 140] Simple package paths, part 1a: Checking tool #252154

Merged
merged 3 commits into from
Aug 30, 2023

Conversation

github-actions[bot]
Copy link
Contributor

Bot-based backport to release-23.05, triggered by a label in #250885.

  • Before merging, ensure that this backport complies with the Criteria for Backporting.
    • Even as a non-commiter, if you find that it does not comply, leave a comment.

Adds an internal CLI tool to verify Nixpkgs to conform to RFC 140.
See pkgs/test/nixpkgs-check-by-name/README.md for more information.

(cherry picked from commit 271eb02)

Had to downgrade some dependencies in the Cargo.lock so that it builds
with the older Rust version.
@infinisil
Copy link
Member

@ofborg build tests.nixpkgs-check-by-name

@infinisil
Copy link
Member

@infinisil
Copy link
Member

Cannot be merged like this just yet: #250885 (comment)

- Better filesystem case-sensitivity heuristic
  We shouldn't assume that Linux is always case-sensitive.
- Don't include case-sensitive filename in tree
  Was used for tests, but this broke channel updates because there's a
  check to make sure there's no case-sensitive files!

  https://hydra.nixos.org/build/233371356/nixlog/1

(cherry picked from commit d42ae66)
@infinisil infinisil merged commit 07e0e7f into release-23.05 Aug 30, 2023
20 checks passed
@infinisil infinisil deleted the backport-250885-to-release-23.05 branch August 30, 2023 19:46
@infinisil infinisil added this to the RFC 140 milestone Sep 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant