nixpkgs-check-by-name: Remove case-sensitive duplicate path from tree #252210
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
- Better filesystem case-sensitivity heuristic We shouldn't assume that Linux is always case-sensitive. - Don't include case-sensitive filename in tree Was used for tests, but this broke channel updates because there's a check to make sure there's no case-sensitive files! https://hydra.nixos.org/build/233371356/nixlog/1
infinisil
force-pushed
the
fix-check-by-name
branch
from
2d6dfd5
to
d42ae66
Compare
|
The failure on Darwin is super weird, it complains about a file that's not even there anymore.. I'll just go ahead and merge this in order to unblock the channel, we can verify that darwin builds later |
|
Can confirm that all platforms in Hydra still build it successfully: https://hydra.nixos.org/eval/1798896?filter=nixpkgs-check-by-name&compare=1798890&full=#tabs-still-succeed |
13 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
The channel updates are blocked because #250885 added a case-sensitive duplicate path to the tree:
This removes the duplicate and generates the file dynamically for the tests instead.
Things done
nix-build -A tests.nixpkgs-check-by-nameonx86_64-linuxnix-build pkgs/top-level/release.nix -A tarball(up the point where it failed before, doesn't fail anymore there)