Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wayland-logout: init at 1.4 #253437

Merged
merged 1 commit into from
Sep 5, 2023
Merged

Conversation

quantenzitrone
Copy link
Contributor

@quantenzitrone quantenzitrone commented Sep 5, 2023

Description of changes

A simple package that logs you out of any Wayland compositor.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@quantenzitrone
Copy link
Contributor Author

as far as i see, this is the first pr using the new pkgs/by-name structure introduced in #237439 🎉

@quantenzitrone
Copy link
Contributor Author

quantenzitrone commented Sep 5, 2023

@wegank why homepage -> website? Website is not a documented meta attribute.
Also, wouldn't it be easier to just wait until RFC 101 gets merged, and the whole codebase gets autoformatted before we try to enforce rules like spaces in lists.
To be clear, I'm also in favor of spaces in lists, but I can't be bothered to add them in manually after alejandra removes them.
When the RFC 101 autoformatter is ready, I will gladly switch to that one.

@wegank
Copy link
Member

wegank commented Sep 5, 2023

@wegank why homepage -> website? Website is not a documented meta attribute.

What I've done is website -> homepage. The PR also had meta.licenses, which is not a valid attribute.

Also, wouldn't it be easier to just wait until RFC 101 gets merged, and the whole codebase gets autoformatted before we try to enforce rules like spaces in lists.

Reverted.

@quantenzitrone
Copy link
Contributor Author

oh bruh sorry im dumb
i'm going to have to be more careful for these attributes

@quantenzitrone
Copy link
Contributor Author

another thing: why remove the trailing comma for ninja?

now ninja always has to be the last argument, because any argument added after ninja would need to change 2 lines

- ninja
+ ninja,
+ anotherdependency

as far as i know, nix has no problem with trailing commas in function arguments,
so even if you remove the ..., the trailing comma could've stayed

@wegank wegank merged commit 1112acf into NixOS:master Sep 5, 2023
20 of 22 checks passed
@quantenzitrone quantenzitrone deleted the wayland-logout branch September 5, 2023 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants