Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wmaker update #254316

Merged
merged 3 commits into from
Sep 10, 2023
Merged

Wmaker update #254316

merged 3 commits into from
Sep 10, 2023

Conversation

AndersonTorres
Copy link
Member

@AndersonTorres AndersonTorres commented Sep 10, 2023

Description of changes

Now with by-name support!

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@@ -36670,8 +36670,7 @@ with pkgs;

windowlab = callPackage ../applications/window-managers/windowlab { };

windowmaker = callPackage ../applications/window-managers/windowmaker { };
dockapps = callPackage ../applications/window-managers/windowmaker/dockapps { };
dockapps = callPackage ../by-name/wi/windowmaker/dockapps { };
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, this is something I didn't expect 😅

I guess it's not a problem, it will fall under a future refactoring of package sets

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Windowmaker dockapps live in a limbo.
In theory they can run in any window manager that provides dockapp support.
However, there are only Windowmaker and Afterstep that provides this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants