-
-
Notifications
You must be signed in to change notification settings - Fork 13.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
engage: 0.1.2 -> 0.1.3 #254460
engage: 0.1.2 -> 0.1.3 #254460
Conversation
Backport failed for Please cherry-pick the changes locally. git fetch origin release-23.05
git worktree add -d .worktree/backport-254460-to-release-23.05 origin/release-23.05
cd .worktree/backport-254460-to-release-23.05
git checkout -b backport-254460-to-release-23.05
ancref=$(git merge-base 7ec9d1f52dfc1bb04a8f73096aa64ce8e99ccc78 2c5f722cfc65ae5a57c896598f6b0137af35ff22)
git cherry-pick -x $ancref..2c5f722cfc65ae5a57c896598f6b0137af35ff22 |
Fyi, now that #253442 is merged, |
Backport failed for Please cherry-pick the changes locally. git fetch origin release-23.05
git worktree add -d .worktree/backport-254460-to-release-23.05 origin/release-23.05
cd .worktree/backport-254460-to-release-23.05
git checkout -b backport-254460-to-release-23.05
ancref=$(git merge-base 7ec9d1f52dfc1bb04a8f73096aa64ce8e99ccc78 2c5f722cfc65ae5a57c896598f6b0137af35ff22)
git cherry-pick -x $ancref..2c5f722cfc65ae5a57c896598f6b0137af35ff22 |
Merge conflict is unfortunate, the |
I just opened a manual backport in draft mode because it doesn't build with 23.05's current rustc version. Edit: and I just closed it because we don't backport rustc. |
Description of changes
Moves
engage
to the newby-name
scheme and updates it to the latest version, which includes a slight behavior change (bugfix) and is backwards-compatible.Things done
sandbox = true
set innix.conf
? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)