Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement check to disallow pkgs/by-name package definitions in all-packages.nix with an empty argument #256792

Merged
merged 7 commits into from
Oct 12, 2023
Merged

Implement check to disallow pkgs/by-name package definitions in all-packages.nix with an empty argument #256792

merged 7 commits into from
Oct 12, 2023

Commits on Oct 12, 2023

  1. tests.nixpkgs-check-by-name: Minor Nix refactor

    @infinisil
    infinisil committed Oct 12, 2023
    Configuration menu
    Copy the full SHA
    21d520f View commit details
    Browse the repository at this point in the history

  2. tests.nixpkgs-check-by-name: Minor refactor 

    Allows a smaller diff for future changes
    @infinisil
    infinisil committed Oct 12, 2023
    Configuration menu
    Copy the full SHA
    6710bc2 View commit details
    Browse the repository at this point in the history

  3. tests.nixpkgs-check-by-name: Add custom argument test

    @infinisil
    infinisil committed Oct 12, 2023
    Configuration menu
    Copy the full SHA
    26cec0d View commit details
    Browse the repository at this point in the history

  4. tests.nixpkgs-check-by-name: Improve an error message

    @infinisil
    infinisil committed Oct 12, 2023
    Configuration menu
    Copy the full SHA
    f394f73 View commit details
    Browse the repository at this point in the history

  5. tests.nixpkgs-check-by-name: auto-calling differentiation 

    Allows detecting whether attributes are overridden in all-packages.nix.
In a future commit we'll use this to detect empty arguments being set in
all-packages.nix and complain about that.
    @infinisil
    infinisil committed Oct 12, 2023
    Configuration menu
    Copy the full SHA
    fcaa408 View commit details
    Browse the repository at this point in the history

  6. tests.nixpkgs-check-by-name: Introduce --version

    @infinisil
    infinisil committed Oct 12, 2023
    Configuration menu
    Copy the full SHA
    23541be View commit details
    Browse the repository at this point in the history

  7. tests.nixpkgs-check-by-name: Disallow empty all-packages.nix overrides 

    Only enabled with `--version v1`
    @infinisil
    infinisil committed Oct 12, 2023
    Configuration menu
    Copy the full SHA
    d3bf613 View commit details
    Browse the repository at this point in the history