turtlevcs: init at 0.6 #257062
turtlevcs: init at 0.6 #257062
Conversation
|
The package needs a |
ofborg
bot
added
11.by: package-maintainer
10.rebuild-darwin: 0
and removed
10.rebuild-darwin: 1
10.rebuild-darwin: 1-10
labels
There was a problem hiding this comment.
Is there a reason you choose the by name category? A similar program (gitkraken) is in pkgs/applications/version-management/ so this might be better suited there as well?
Additionally, I think you should also put a call to the program in pkgs/top-level/all-packages.nix.
After this it would also be much easier for me to test the PR
It is recommended in the documentation (since #237439 was merged). When using the pkgs/by-name hierarchy there is no need to modify all-packages.nix. |
|
oops, thanks for the heads up! |
BurNiinTRee
force-pushed
the
turtlevcs
branch
from
e7cf09e
to
f0f67c9
Compare
|
I removed the trailing comma and set |
BurNiinTRee
force-pushed
the
turtlevcs
branch
from
f0f67c9
to
096980b
Compare
|
Done |
|
Wow, this is nice! Although it has been sitting for a while... Let me see if ofborg complains...
|
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/prs-already-reviewed/2617/1452 |
| preFixup = '' | ||
| makeWrapperArgs+=("''${gappsWrapperArgs[@]}") | ||
| # It can't find pygit2 without also adding $PYTHONPATH to the wrapper | ||
| makeWrapperArgs+=( --prefix PYTHONPATH : $out/${python3.sitePackages}:$PYTHONPATH ) |
There was a problem hiding this comment.
We cannot use $PYTHONPATH like this as it draws in build time dependencies
| rev = version; | ||
| hash = "sha256-ShZlGZeIjsMOLrdPsl6WphGZcWPrhTQHv2b7HFVm4do="; | ||
| }; | ||
| format = "setuptools"; |
There was a problem hiding this comment.
Please use the new pyproject = true setting instead of format
| python3.pkgs.buildPythonApplication rec { | ||
| pname = "turtle"; | ||
| version = "0.6"; | ||
| src = fetchFromGitLab { |
There was a problem hiding this comment.
A new line here and there similar to other packages would help readability a lot.
| description = "A graphical interface for version control intended to run on gnome and nautilus"; | ||
| homepage = "https://gitlab.gnome.org/philippun1/turtle"; | ||
| license = licenses.gpl3Plus; | ||
| maintainers = with maintainers; [ burniintree ]; |
There was a problem hiding this comment.
| maintainers = with maintainers; [ burniintree ]; | |
| mainProgram = "turtle"; | |
| maintainers = with maintainers; [ burniintree ]; |
Aleksanaa
added
the
2.status: stale
Closes #252317
Adds a turtle package.
The nautilus plugin requires
gnome.nautilus-pythonto be installed separately.The package is a bit weird, since
turtle_clisubcommands are implemented through subprocessesof either
$PYTHONorsys.executable. This doesn't work well withbuildPythonApplications hooksfor setting up python dependencies.
I'm not very familiar with neither python packaging in general, nor nixpkgs' infrastructure for it,
so there might be better ways of achieving this.
Description of changes
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)