dell-command-configure: init at 4.8.0-494 #260715
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: |
mrcjkb
suggested changes
Oct 12, 2023
RyanGibb
force-pushed
the
dell-command-configure
branch
from
24e6d08
to
2e0f16a
Compare
RyanGibb
force-pushed
the
dell-command-configure
branch
from
2e0f16a
to
4f5476d
Compare
|
@mrcjkb thanks for the review! please find all you comments addressed now. |
mrcjkb
approved these changes
Oct 13, 2023
amaxine
approved these changes
Oct 17, 2023
13 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Adds dell-command-configure utility.
Similar to #84926 but uses NixOS/patchelf#459 to patch the binary to look for the configuration file in the derivation to avoid requiring a module with a one shot systemd service.
Closes RyanGibb/nixos#1.
Things done
./result/bin/)