-
-
Notifications
You must be signed in to change notification settings - Fork 13.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
usrsctp: fix build with clang 15+ #262809
Conversation
I don't think it's a good idea to update this library to some random commit. Maybe there's a way to fix this clang16 issue while still using a tagged release. |
Ideally, but that letter assumes projects doing regular releases, which is not the case here. This one doesn’t. It only has three releases, and the last release was very minor (just cleaning up .so versioning). In the issue requesting what would become the 0.9.4.0 release, it was questioned why people couldn’t just use snapshots instead. The release notes for that version are simply, “Current status as requested in #561.”
Sure, I can write and vendor a patch in nixpkgs. I normally like the to cherry-pick commits from upstream that fix the issue, but those here are mixed in with changes other than just the fixes. I rebased my staging branch last night, so it’s going to be a little while before I have a patch, but I should be able to update this PR by this evening EDT. |
d42d40a
to
63e3e43
Compare
* Add missing function prototypes; and * Remove set but unused variables.
63e3e43
to
9658c77
Compare
I updated the PR with a patch to remove the unused variables and add the missing prototypes. I initially tried applying the commits from upstream FreeBSD that did this, but they didn’t apply cleanly, so I made the changes manually to create the included patch. I also retargeted to staging. |
Description of changes
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)