Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pkgs/by-name: Enable gradual migration checks and add run-local.sh #274591

Merged
merged 8 commits into from
Dec 21, 2023
Merged

pkgs/by-name: Enable gradual migration checks and add run-local.sh #274591

merged 8 commits into from
Dec 21, 2023

Commits on Dec 19, 2023

  1. workflows/check-by-name: Move tool fetching into script 

    This part of the CI can also be reproduced locally
    @infinisil
    infinisil committed Dec 19, 2023
    Configuration menu
    Copy the full SHA
    3869ba4 View commit details
    Browse the repository at this point in the history

  2. workflows/check-by-name: Why the mergeability check needs to be inline

    @infinisil
    infinisil committed Dec 19, 2023
    Configuration menu
    Copy the full SHA
    c626788 View commit details
    Browse the repository at this point in the history

Commits on Dec 20, 2023

  1. tests.nixpkgs-check-by-name: Create script to run locally 

    Due to the check soon depending on the base branch (see `--base`),
the CI check can't reasonably share all code with a local check.
We can still make a script to run it locally, just not sharing all code.
    @infinisil
    infinisil committed Dec 20, 2023
    Configuration menu
    Copy the full SHA
    92238ac View commit details
    Browse the repository at this point in the history

  2. tests.nixpkgs-check-by-name: Add documentation for scripts

    @infinisil
    infinisil committed Dec 20, 2023
    Configuration menu
    Copy the full SHA
    9e03178 View commit details
    Browse the repository at this point in the history

  3. workflows/check-by-name: Slim down and prepare for --base 

    Now that we have a script to run the check locally,
there's no real need to output the information to reproduce anymore,
which allows cleaning up the CI workflow.

Furthermore, this prepares the CI workflow to be passed `--base`, as
introduced recently.
    @infinisil
    infinisil committed Dec 20, 2023
    Configuration menu
    Copy the full SHA
    1ad45e5 View commit details
    Browse the repository at this point in the history

  4. check-by-name: Pass --base in CI and local running script 

    This enables the ratchet checks for pkgs/by-name, allowing gradual
migrations!
    @infinisil
    infinisil committed Dec 20, 2023
    Configuration menu
    Copy the full SHA
    1968bee View commit details
    Browse the repository at this point in the history

Commits on Dec 21, 2023

  1. maintainers/scripts/check-by-name.sh: Introduce symlink alias

    @infinisil
    infinisil committed Dec 21, 2023
    Configuration menu
    Copy the full SHA
    f882df7 View commit details
    Browse the repository at this point in the history

  2. pkgs/test/nixpkgs-check-by-name/scripts: Various improvements 

    - trace function, avoids littering `echo >&2` all throughout
- Avoid `eval`, remove unneeded shellcheck

Co-Authored-By: Victor Engmark <[email protected]>
    @infinisil @l0b0
    infinisil and l0b0 committed Dec 21, 2023
    Configuration menu
    Copy the full SHA
    e130ee3 View commit details
    Browse the repository at this point in the history