-
-
Notifications
You must be signed in to change notification settings - Fork 13.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docker_25: init at 25.0.3 #278607
docker_25: init at 25.0.3 #278607
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cross posting #278531 (comment) because of the change to LimitNOFILE = 1048576;
made in b854c8a.
The reasoning in moby/moby#45534 (comment) sounds good to me in favor of using systemd's defaults. Removing the explicit setting of |
268ffb1
to
d87a5ad
Compare
@infinisil is the failing I did not immediately spot documentation for that |
False positive, please ignore, master won't break from merging like this! Am working on a fix for this :) |
Will be fixed with #285089 |
b7e4d8d
to
b531ee6
Compare
Result of 2 packages marked as broken and skipped:
20 packages built:
|
The PR to fix the |
Thanks @infinisil :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated hashes for v25.0.3
disclaimer: I'm a Docker Inc employee but I'm not actually a Moby maintainer
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🐯
would love to see this PR merged! we're waiting on some new OCI compliant layer remote cache features. |
Description of changes
Release notes:
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.