spotify-cli: init at 0.3.12 #284327
Open
spotify-cli: init at 0.3.12 #284327
+40
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andreivolt
force-pushed
the
spotify-cli
branch
2 times, most recently
from
ad35e64
to
e7ed6ac
Compare
oliviacrain
approved these changes
Jan 28, 2024
|
@oliviacrain thanks for the feedback! let me know if all is well this time |
andreivolt
force-pushed
the
spotify-cli
branch
from
8728ce7
to
b96993c
Compare
andreivolt
force-pushed
the
spotify-cli
branch
from
b96993c
to
e0144c5
Compare
oliviacrain
reviewed
Jan 28, 2024
There was a problem hiding this comment.
Added some more comments- apologies for missing these on the first round, I'm new to reviewing in nixpkgs. And apologies as well for marking as approved on the first iteration, that was a misclick.
The commit adding the maintainer list entry should come before the commit adding the package.
Maintainer entry itself looks good. GitHub ID matches the account listed. GPG fingerprint matches key listed on profile, and all commits are signed by that key.
andreivolt
force-pushed
the
spotify-cli
branch
from
e0144c5
to
6cf406e
Compare
|
@oliviacrain And I'm new to contributing to |
andreivolt
force-pushed
the
spotify-cli
branch
from
6cf406e
to
836446d
Compare
andreivolt
force-pushed
the
spotify-cli
branch
from
836446d
to
a77b160
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.