-
-
Notifications
You must be signed in to change notification settings - Fork 13.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sbcl: 2.4.0 -> 2.4.1 #284591
sbcl: 2.4.0 -> 2.4.1 #284591
Conversation
2e089b8
to
c0cb7a7
Compare
Ah apparently the check by @infinisil checks for new top-level call and not for new files being called from the top-level, so the directory has to be moved to |
Hmm it wants |
The RFC lists this under "future work":
But it's blocking this PR now |
Sorry this is a false positive, feel free to ignore! I'm currently working on a fix |
@ofborg build sbcl.pkgs.iolib sbcl.pkgs.stumpwm |
|
Turns out this shouldn't have been allowed by CI after all, but for different reasons! Check out #287083 for more details, we have to move |
Description of changes
Also rename to package.nix to make CI pass. Haven't stayed up to date with the developments around this but I guess this works.
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.