nist-feed: init at 0-unstable-2024-01-20 #284812
Conversation
|
Successor of #284782 |
|
@octodi does it contain also the module, right? |
Yup |
|
@octodi according to the new guidelines, you must change title and commit message from |
octodi
changed the title
Update nixos/modules/programs/nist-feed.nix
| <<<<<<< HEAD | ||
| - [NIST-Feed](https://github.com/d3vil0p3r/nist-feed), notifies you about the newest published CVEs from NIST. Available as [programs.nist-feed](#opt-programs.nist-feed.enable). | ||
| ======= | ||
| - [ALVR](https://github.com/alvr-org/alvr), a VR desktop streamer. Available as [programs.alvr](#opt-programs.alvr.enable) | ||
| >>>>>>> master |
There was a problem hiding this comment.
There seems to be a conflict left over here
| }; | ||
|
|
||
| patches = [ | ||
| ./cron.patch |
There was a problem hiding this comment.
Maybe the name of this patch could be a bit more descriptive?
remove-cronjob-instantiation-feature.patch or something along those lines?
There was a problem hiding this comment.
should definitely have a comment explaining why it's needed and/or why it couldn't be upstreamed
Co-authored-by: h7x4 <[email protected]>
Co-authored-by: h7x4 <[email protected]>
Co-authored-by: h7x4 <[email protected]>
Co-authored-by: h7x4 <[email protected]>
Co-authored-by: h7x4 <[email protected]>
This reverts commit 01ef3c2.
| @@ -0,0 +1,54 @@ | |||
| { config, lib, pkgs, ... }: | |||
|
|
|||
| with lib; | |||
There was a problem hiding this comment.
| with lib; |
Bad practice that's now discouraged in nixpkgs.
Tracking issue: #208242
| extraArgs = mkOption { | ||
| type = with types; listOf str; | ||
| default = [ "-l" "-s" "CRITICAL" ]; | ||
| description = mdDoc '' |
There was a problem hiding this comment.
| description = mdDoc '' | |
| description = '' |
lib.mdDoc is no longer present in nixpkgs; please remove all usages.
| runHook postInstall | ||
| ''; | ||
|
|
||
| meta = with lib; { |
There was a problem hiding this comment.
| meta = with lib; { | |
| meta = { |
Tracking issue: #292468
| license = licenses.gpl3Plus; | ||
| maintainers = with maintainers; [ octodi ]; |
There was a problem hiding this comment.
| license = licenses.gpl3Plus; | |
| maintainers = with maintainers; [ octodi ]; | |
| license = lib.licenses.gpl3Plus; | |
| maintainers = with lib.maintainers; [ octodi ]; |
| }; | ||
|
|
||
| patches = [ | ||
| ./cron.patch |
There was a problem hiding this comment.
should definitely have a comment explaining why it's needed and/or why it couldn't be upstreamed
| description = "A notification daemon for CVEs"; | ||
| serviceConfig = { | ||
| Type = "oneshot"; | ||
| ExecStart = "${cfg.package}/bin/nist-feed ${escapeShellArgs cfg.extraArgs}"; |
There was a problem hiding this comment.
| ExecStart = "${cfg.package}/bin/nist-feed ${escapeShellArgs cfg.extraArgs}"; | |
| ExecStart = "${lib.getExe cfg.package} ${escapeShellArgs cfg.extraArgs}"; |
Description of changes
Added NIST-Feed notifies you about the newest published CVEs according your filters
https://github.com/d3vil0p3r/nist-feed
Related to #81418
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.