Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

papers: init at 45.0-unstable-2024-03-27 #299579

Merged
merged 1 commit into from
Apr 15, 2024
Merged

Conversation

Jo-Blade
Copy link
Contributor

@Jo-Blade Jo-Blade commented Mar 27, 2024

Description of changes

Initial package for Papers : https://gitlab.gnome.org/GNOME/Incubator/papers
This is a replacement of the evince pdf viewer with a new GTK4/Libadwaita UI written in rust.

This was proposed as "good to have" in the next gnome-46 release, see #291339

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@Jo-Blade Jo-Blade requested a review from jtojnar as a code owner March 27, 2024 20:27
@github-actions github-actions bot added the 6.topic: GNOME GNOME desktop environment and its underlying platform label Mar 27, 2024
@amaxine
Copy link
Contributor

amaxine commented Mar 27, 2024

Thanks for taking the initiative! We don't really add new packages to the gnome space anymore - this should go into pkgs/by-name instead. Since they haven't actually tagged a release, the version should be unstable-DATE, rather than 0.1.0 - once they tag a release it appears it'll follow standard gnome versioning.

@github-actions github-actions bot removed the 6.topic: GNOME GNOME desktop environment and its underlying platform label Mar 30, 2024
@Jo-Blade
Copy link
Contributor Author

Thanks for taking the initiative! We don't really add new packages to the gnome space anymore - this should go into pkgs/by-name instead. Since they haven't actually tagged a release, the version should be unstable-DATE, rather than 0.1.0 - once they tag a release it appears it'll follow standard gnome versioning.

Thanks for your feedback, I've fixed these problems with today's latest commit. Please say to me if it is good now

@jtojnar
Copy link
Member

jtojnar commented Apr 2, 2024 via email

@SuperSandro2000
Copy link
Member

Can you clean up the history especially squash the review commits?

@ofborg eval

@Jo-Blade
Copy link
Contributor Author

Jo-Blade commented Apr 8, 2024

Can you clean up the history especially squash the review commits?

@ofborg eval

Of course ! Just done it now

@Jo-Blade Jo-Blade mentioned this pull request Apr 8, 2024
27 tasks
@amaxine
Copy link
Contributor

amaxine commented Apr 9, 2024

@Jo-Blade I think with all the fixups, the correct commit message is now papers: init at 45.0-unstable-2024-03-27. That should fix the eval errors.

Thanks for doing this work!

@Jo-Blade
Copy link
Contributor Author

Jo-Blade commented Apr 9, 2024

@Jo-Blade I think with all the fixups, the correct commit message is now papers: init at 45.0-unstable-2024-03-27. That should fix the eval errors.

Thanks for doing this work!

You're totally right ! I just updated it now ;)

@amaxine amaxine changed the title gnome.papers: init at 0.1.0 papers: init at 45.0-unstable-2024-03-27 Apr 9, 2024
@onny
Copy link
Contributor

onny commented Apr 15, 2024

Result of nixpkgs-review pr 299579 run on x86_64-linux 1

3 packages built:
  • papers
  • papers.dev
  • papers.devdoc

@onny onny self-requested a review April 15, 2024 16:47
@amaxine amaxine merged commit ece103f into NixOS:gnome-46 Apr 15, 2024
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants