-
-
Notifications
You must be signed in to change notification settings - Fork 13.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pybibget: init at 0.1.0 #300039
pybibget: init at 0.1.0 #300039
Conversation
Hi, If your PR is ready for review, please squash the commit into the standard format: for each package, write If you don't know how to write a commit message, you can find some examples in the same file or other similar commit logs. Hope this helps you! |
df85b64
to
06b3f3a
Compare
@ofborg build python311Packages.pybibget python312Packages.pybibget |
wait, is this a CLI or a library? if it's solely the former, it should go in |
It is a CLI. Ok, I will then put it in a correct location |
06b3f3a
to
31cf392
Compare
31cf392
to
532523a
Compare
The package is at the correct location now. Checked the compiled binaries - they work |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks good, tested and ran the binaries, they seem to work.
Couple points remaining and I'll approve after.
532523a
to
0f285b4
Compare
Thank you for your time! |
@ofborg eval |
It has been sitting here for 2 months, all checks pass, I was wondering when we could merge this? |
Apologies, was waiting for CI to clear and it fell off the radar. Thanks for your contribution! |
Description of changes
A python package to obtain .bib information about papers from doi, arxiv, etc.
Homepage
Added myself as a maintainer. Please, let me know if there are any issues.
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.