Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pybibget: init at 0.1.0 #300039

Merged
merged 2 commits into from
Jun 12, 2024
Merged

pybibget: init at 0.1.0 #300039

merged 2 commits into from
Jun 12, 2024

Conversation

Vasissualiyp
Copy link
Contributor

@Vasissualiyp Vasissualiyp commented Mar 29, 2024

Description of changes

A python package to obtain .bib information about papers from doi, arxiv, etc.
Homepage

Added myself as a maintainer. Please, let me know if there are any issues.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@Aleksanaa
Copy link
Member

Hi, If your PR is ready for review, please squash the commit into the standard format: for each package, write foo: init at 1.0.0, and maintainers: add foo.

If you don't know how to write a commit message, you can find some examples in the same file or other similar commit logs. Hope this helps you!

@eclairevoyant
Copy link
Member

@ofborg build python311Packages.pybibget python312Packages.pybibget

@eclairevoyant
Copy link
Member

wait, is this a CLI or a library? if it's solely the former, it should go in pkgs/by-name and use buildPythonApplication

@Vasissualiyp
Copy link
Contributor Author

It is a CLI. Ok, I will then put it in a correct location

@Vasissualiyp
Copy link
Contributor Author

The package is at the correct location now. Checked the compiled binaries - they work

Copy link
Member

@eclairevoyant eclairevoyant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good, tested and ran the binaries, they seem to work.
Couple points remaining and I'll approve after.

pkgs/by-name/py/pybibget/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/py/pybibget/package.nix Outdated Show resolved Hide resolved
@Vasissualiyp
Copy link
Contributor Author

Thank you for your time!
Have force-pushed all the requested changes.

@eclairevoyant eclairevoyant changed the title Add pybibget pybibget: init at 0.1.0 Apr 8, 2024
@eclairevoyant
Copy link
Member

@ofborg eval

@Vasissualiyp
Copy link
Contributor Author

It has been sitting here for 2 months, all checks pass, I was wondering when we could merge this?

@eclairevoyant
Copy link
Member

Apologies, was waiting for CI to clear and it fell off the radar. Thanks for your contribution!

@eclairevoyant eclairevoyant merged commit 1729f1a into NixOS:master Jun 12, 2024
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants