simp: init at 3.5.3

[oluceps]

Description of changes

fixes #315819
@RAVENz46 for testing.

Things done

• Built on platform(s)
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
  • sandbox = relaxed
  • sandbox = true
• Tested, as applicable:
  • NixOS test(s) (look inside nixos/tests)
  • and/or package tests
  • or, for functions and "core" functionality, tests in lib/tests or pkgs/test
  • made sure NixOS tests are linked to the relevant packages
• Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
• Tested basic functionality of all binary files (usually in ./result/bin/)
• 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
  • (Package updates) Added a release notes entry if the change is major or breaking
  • (Module updates) Added a release notes entry if the change is significant
  • (Module addition) Added a release notes entry if adding a new NixOS module
• Fits CONTRIBUTING.md.

---

Add a 👍 reaction to pull requests you find important.

[eclairevoyant]

Seems to fail at runtime, on sway:

PanicInfo { payload: Any { .. }, message: Some(called `Result::unwrap()` on an `Err` value: Os(OsError { line: 80, file: "/build/simp-3.5.3-vendor.tar.gz/winit/src/platform_impl/linux/wayland/event_loop/mod.rs", error: WaylandError(Connection(NoWaylandLib)) })), location: Location { file: "src/main.rs", line: 67, col: 92 }, can_unwind: true, force_no_backtrace: false }

[eclairevoyant]

This should fix the runtime failures and also add AVIF and HEIF/HEIC support (I haven't tested the extra support yet, though.)

[RAVENz46]

Hi! Thanks for your work.

I also tried write derivation by myself and now it launch successfully.
It may still miss/include-unnecessary some dependencies but I hope it helps you.

{ lib
, rustPlatform
, fetchFromGitHub
, pkg-config
, libxkbcommon
, vulkan-loader
, stdenv
, darwin
, wayland
, makeDesktopItem
, copyDesktopItems
, cargo-about
, libGL
}:

rustPlatform.buildRustPackage rec {
  pname = "simp";
  version = "3.5.3";

  src = fetchFromGitHub {
    owner = "Kl4rry";
    repo = "simp";
    rev = "v${version}";
    hash = "sha256-NALVHcU+NhCT5w+pn6WhP+cFGPuDhnPt+IDNHN/oqls=";
  };

  cargoHash = "sha256-Wp50ldXGy7MLQTnvZDx3LIr8jLBpkoCrh0/xPowIn54=";

  nativeBuildInputs = [
    pkg-config
    cargo-about
    copyDesktopItems
  ];

  buildInputs = [
    libxkbcommon
    vulkan-loader
    libGL
  ] ++ lib.optionals stdenv.isDarwin [
    darwin.apple_sdk.frameworks.AppKit
    darwin.apple_sdk.frameworks.CoreGraphics
    darwin.apple_sdk.frameworks.CoreServices
    darwin.apple_sdk.frameworks.Foundation
    darwin.apple_sdk.frameworks.Metal
    darwin.apple_sdk.frameworks.QuartzCore
  ] ++ lib.optionals stdenv.isLinux [
    wayland
  ];

  desktopItems = [
    (makeDesktopItem {
      name = "simp";
      desktopName = "simp";
      genericName= "Image Editor";
      exec = "simp %U";
      icon = "icon";
      categories = [ "Graphics" ];
      mimeTypes = [ "image/bmp" ];
    })
  ];

  preBuild = ''
    mkdir -p $out/share/icons/hicolor/256x256/apps
    cp $src/icon.png $out/share/icons/hicolor/256x256/apps/
    sed -i '35,39c let git_hash=String::from("${version}");' build.rs
  '';

  postFixup = ''
    patchelf $out/bin/${pname} \
      --add-rpath ${lib.makeLibraryPath [ vulkan-loader libGL libxkbcommon wayland ]}
  '';

  meta = {
    description = "Simp is a fast and simple GPU-accelerated image manipulation program";
    homepage = "https://github.com/Kl4rry/simp";
    license = lib.licenses.asl20;
    maintainers = with lib.maintainers; [ ];
    mainProgram = "simp";
  };
}

[eclairevoyant]

It appears to run and not-crash now, but I can't load any image for some reason? e.g. File > Open, File > Open Folder, Ctrl + O and Ctrl + V (with some image in the clipboard) all don't work. Not sure where to go from here

[Aleksanaa]

Still panic on my side

=> ./result/bin/simp
PanicInfo { payload: Any { .. }, message: Some(called `Result::unwrap()` on an `Err` value: Timeout), location: Location { file: "src/main.rs", line: 280, col: 69 }, can_unwind: true, force_no_backtrace: false }

[SuperSandro2000]

This should be a patch. Using sed like this is extremely brittle