Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chrysalis: mark update script executable, fix source provenance, and other cleanup #316835

Merged
merged 8 commits into from
Jun 24, 2024

Conversation

eclairevoyant
Copy link
Member

@eclairevoyant eclairevoyant commented Jun 3, 2024

Description of changes

  • mark update script executable
  • fix source provenance
  • format with nixfmt-rfc-style
  • remove meta = with lib; (tracking issue: Documentation: style guide for use of with #292468)
  • fix pname misuse
  • replace deprecated --replace with --replace-fail
  • fix meta.mainProgram

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@eclairevoyant eclairevoyant changed the title chrysalis: mark update script executable chrysalis: mark update script, fix source provenance, and other cleanup Jun 3, 2024
@eclairevoyant eclairevoyant changed the title chrysalis: mark update script, fix source provenance, and other cleanup chrysalis: mark update script executable, fix source provenance, and other cleanup Jun 3, 2024
@eclairevoyant eclairevoyant marked this pull request as draft June 3, 2024 08:23
@eclairevoyant eclairevoyant marked this pull request as ready for review June 3, 2024 08:37
@ofborg ofborg bot requested review from nshalman and herrwiese June 3, 2024 09:29
@eclairevoyant eclairevoyant merged commit a4853d2 into NixOS:master Jun 24, 2024
23 of 24 checks passed
@eclairevoyant eclairevoyant deleted the fix-chrysalis-script branch June 24, 2024 22:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant