Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pkgs/top-level/make-tarball.nix: avoid hardlinks #317122

Merged
merged 1 commit into from
Jun 4, 2024

Conversation

vcunat
Copy link
Member

@vcunat vcunat commented Jun 4, 2024

For context see NixOS/nix#10395 and cross-linked discussions.

Things done

  • Built on platform(s)
    • x86_64-linux and checked that hardlinks were avoided (on a machine with auto-optimize-store = true)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@nlewo
Copy link
Member

nlewo commented Jun 4, 2024

Note we already encountered same kind of issues when building a Docker layer: https://github.com/nixos/nixpkgs/blob/ae983e03fa6dc7f15a3b35fbf3ac606149a16b88/pkgs/build-support/docker/default.nix#L413

@infinisil infinisil merged commit cc648ec into NixOS:master Jun 4, 2024
6 of 7 checks passed
Copy link
Contributor

github-actions bot commented Jun 4, 2024

Backport failed for release-23.11, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin release-23.11
git worktree add -d .worktree/backport-317122-to-release-23.11 origin/release-23.11
cd .worktree/backport-317122-to-release-23.11
git switch --create backport-317122-to-release-23.11
git cherry-pick -x 72e89d74616d06080f897e2fb237c4845c264bf4

Copy link
Contributor

github-actions bot commented Jun 4, 2024

Successfully created backport PR for release-24.05:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants