Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python311Packages.curvefitgui: init at 0-unstable-2021-08-25 #317144

Merged
merged 1 commit into from
Jun 8, 2024
Merged

python311Packages.curvefitgui: init at 0-unstable-2021-08-25 #317144

merged 1 commit into from
Jun 8, 2024

Conversation

doronbehar
Copy link
Contributor

Motivation for this change
Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.05 Release Notes (or backporting 21.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

OPNA2608
OPNA2608 requested changes Jun 4, 2024
View reviewed changes
Copy link
Contributor

@OPNA2608 OPNA2608 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also maybe get rid of meta-wide with lib;: #292468 (comment)

pkgs/development/python-modules/curvefitgui/default.nix Outdated Show resolved Hide resolved
pkgs/development/python-modules/curvefitgui/default.nix Outdated Show resolved Hide resolved
@doronbehar
Copy link
Contributor Author

Thanks for the review! I used nix-init which has a lot of related open issues regarding the topics you mentioned.

@doronbehar doronbehar requested a review from OPNA2608 June 5, 2024 06:42
@doronbehar
Copy link
Contributor Author

Disabled this on Python3.12, due to moosepy/curvefitgui#2 .

@OPNA2608 OPNA2608 changed the title python312Packages.curvefitgui: init at unstable-2021-08-25 python312Packages.curvefitgui: init at 0-unstable-2021-08-25 Jun 5, 2024
OPNA2608
OPNA2608 reviewed Jun 5, 2024
View reviewed changes
Copy link
Contributor

@OPNA2608 OPNA2608 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commit name needs to be adjusted for the 0- in the version as well.

pkgs/development/python-modules/curvefitgui/default.nix Outdated Show resolved Hide resolved
@doronbehar doronbehar changed the title python312Packages.curvefitgui: init at 0-unstable-2021-08-25 python311Packages.curvefitgui: init at 0-unstable-2021-08-25 Jun 6, 2024
@doronbehar doronbehar requested a review from OPNA2608 June 7, 2024 08:35
@OPNA2608
Copy link
Contributor

OPNA2608 commented Jun 7, 2024

Commit name needs to be adjusted for the 0- in the version as well.

This still. Ah, and format with nixfmt-rfc-style.

@doronbehar
Copy link
Contributor Author

Commit name needs to be adjusted for the 0- in the version as well.

This still. Ah, and format with nixfmt-rfc-style.

Done both!

OPNA2608
OPNA2608 approved these changes Jun 8, 2024
View reviewed changes
Copy link
Contributor

@OPNA2608 OPNA2608 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@OPNA2608 OPNA2608 merged commit b0f9cc0 into NixOS:master Jun 8, 2024
25 checks passed
@doronbehar
Copy link
Contributor Author

Thanks :).

@doronbehar doronbehar deleted the pkg/python-curvefitgui branch June 8, 2024 22:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OPNA2608 OPNA2608 OPNA2608 approved these changes

Assignees
No one assigned
Labels
6.topic: python 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer 12.approvals: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@doronbehar @OPNA2608