irrd: 4.4.2 -> 4.4.4; fix build

[yu-re-ka]

Description of changes

Things done

• Built on platform(s)
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
  • sandbox = relaxed
  • sandbox = true
• Tested, as applicable:
  • NixOS test(s) (look inside nixos/tests)
  • and/or package tests
  • or, for functions and "core" functionality, tests in lib/tests or pkgs/test
  • made sure NixOS tests are linked to the relevant packages
• Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
• Tested basic functionality of all binary files (usually in ./result/bin/)
• 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
  • (Package updates) Added a release notes entry if the change is major or breaking
  • (Module updates) Added a release notes entry if the change is significant
  • (Module addition) Added a release notes entry if adding a new NixOS module
• Fits CONTRIBUTING.md.

---

Add a 👍 reaction to pull requests you find important.

[superherointj]

Suggestions:

• Move package from top-level to by-name.
• On following phases order (execution order):
  • postPatch is out of phases order.
  • pythonRelaxDeps is either patch phase or configure phase (it edit files), I'd put it in between patch/configure.
• Remove nested with at meta. [optional]
• commit message: fix build should be at body. (I can squash it, in case you don't feel like it.)

Self-promotion:

• Optional: Consider reviewing: python: automate pythonRelaxDepsHook #319432
  (Trying to avoid adding pythonRelaxDepsHook, but here is necessary debt. :-)

[superherointj]

Result of nixpkgs-review pr 319522 run on x86_64-linux 1

2 packages failed to build:

• irrd
• irrd.dist

Failure could be specific to my host, idk yet. This is second build that fails.

[yu-re-ka]

No, some tests are still failing. I'm working on it.

[yu-re-ka]

@superherointj where is this order you are referring to defined?

[superherointj]

@superherointj where is this order you are referring to defined?

https://nixos.org/manual/nixpkgs/stable/#sec-stdenv-phases

By defined, if you meant mandatory, I don't know, likely isn't. But it is usual to list entries by phases order which is the order of execution. The phases are hooks that happens in sequence. Errors also shows up in sequence too. In case, you don't want to do this, no problem.

[yu-re-ka]

I think the phases/definitions should be in order of execution now. If not, tell me what I need to change.

Also the build is fixed now.

[yu-re-ka]

Remove nested with at meta. [optional]

I disagree, I prefer the with; syntax as-is.

commit message: fix build should be at body. (I can squash it, in case you don't feel like it.)

I disagree. The commit does two things at once and both should be visible from reading the first line.

[superherointj]

Result of nixpkgs-review pr 319522 run on x86_64-linux 1

2 packages built:

• irrd
• irrd.dist

[superherointj]

I disagree, I prefer the with; syntax as-is.

Not a blocker. But to clarify, nested with suggestion is not based on syntax, but in avoiding issues in static analysis and some quirks like:
#292468 (comment)

[github-actions]

Successfully created backport PR for release-24.05:

• [Backport release-24.05] irrd: 4.4.2 -> 4.4.4; fix build #319593