sozi: init at 23.7.25-1690311612

[srghma]

Description of changes

adding sozi

Things done

• Built on platform(s)
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
  • sandbox = relaxed
  • sandbox = true
• Tested, as applicable:
  • NixOS test(s) (look inside nixos/tests)
  • and/or package tests
  • or, for functions and "core" functionality, tests in lib/tests or pkgs/test
  • made sure NixOS tests are linked to the relevant packages
• Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
• Tested basic functionality of all binary files (usually in ./result/bin/)
• 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
  • (Package updates) Added a release notes entry if the change is major or breaking
  • (Module updates) Added a release notes entry if the change is significant
  • (Module addition) Added a release notes entry if adding a new NixOS module
• Fits CONTRIBUTING.md.

---

Add a 👍 reaction to pull requests you find important.

[afh]

Thanks for this PR, @srghma, much appreciated.

Please find below a few ideas and suggestions on how to improve this PR. Hopefully I've been able to give understandable and helpful feedback. Do let me know if there are any questions.

[afh]

Thank you for accepting the review suggestions, @srghma, much appreciated 👍

Can you please squash all commits into a single one.

[afh]

If you wanted to go above and beyond you could also format the file using nixfmt, e.g. nix run github:NixOS/nixfmt -- pkgs/by-name/so/sozi/package.nix

[eclairevoyant]

Thanks for the contribution! Some feedback below:

[eclairevoyant]

Also per CI, the URL doesn't seem to exist?

       >
       > trying https://github.com/sozi-projects/Sozi/releases/download/v23.7/Sozi-23.7.25-1690311612.AppImage
       >   % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
       >                                  Dload  Upload   Total   Spent    Left  Speed
       >   0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
       > curl: (22) The requested URL returned error: 404
       > error: cannot download Sozi-23.7.25-1690311612.AppImage from any mirror

[eclairevoyant]

Also, please squash the commits + rebase your branch on a recent commit, 171a116 is from October 2023 and is the reason why you were seeing a lot of strange behaviour.

[afh]

Thanks for addressing all the review comments, @srghma, very much appreciated. What's your take on the following?

feedback addressed

[eclairevoyant]

SVG files appear to open fine, lgtm

[eclairevoyant]

Suggested change

	--replace 'Exec=AppRun' 'Exec=sozi'
	--replace-fail 'Exec=AppRun' 'Exec=sozi'

as --replace is deprecated