Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

py7zr: init at 0.21.1 #324293

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

py7zr: init at 0.21.1 #324293

wants to merge 6 commits into from

Conversation

ByteSudoer
Copy link
Contributor

Description of changes

py7zr is a library and utility to support 7zip archive compression, decompression, encryption and decryption written by Python programming language.
Metadata

This PR also introduces these packages:

  • pyzstd: init at 0.16.0
  • pyppmd: init at 1.1.0
  • pybcj: init at 1.0.2
  • multivolumefile: init at 0.2.3
  • inflate64: init at 1.0.0

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@eclairevoyant
Copy link
Member

FYI if you put Closes #324207 in the description, it will close that issue when this gets merged

Copy link
Member

@eclairevoyant eclairevoyant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. I've provided some feedback below; I've avoided repeating the same feedback, but please consider these as applicable to all the packages.

pkgs/development/python-modules/inflate64/default.nix Outdated Show resolved Hide resolved
pkgs/development/python-modules/inflate64/default.nix Outdated Show resolved Hide resolved
pkgs/development/python-modules/inflate64/default.nix Outdated Show resolved Hide resolved
Copy link
Member

@SuperSandro2000 SuperSandro2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please double check to run all available tests if feasible with pytestCheckHook?

Comment on lines +11 to +12

format = "pyproject";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
format = "pyproject";
pyproject = true;

please replace all occurrences of this

Comment on lines +19 to +26


build-system = [
setuptools
setuptools-scm
];


Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
build-system = [
setuptools
setuptools-scm
];
build-system = [
setuptools
setuptools-scm
];

license = licenses.gpl2Plus;
maintainers = with maintainers; [ ByteSudoer ];
};

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change

Comment on lines +18 to +27
};


build-system = [
setuptools
setuptools-scm
];


pythonImportsCheck = [ "bcj" "lzma" ];
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
};
build-system = [
setuptools
setuptools-scm
];
pythonImportsCheck = [ "bcj" "lzma" ];
};
build-system = [
setuptools
setuptools-scm
];
pythonImportsCheck = [ "bcj" "lzma" ];

, setuptools
, setuptools-scm

, pytest
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is unused

Comment on lines +13 to +20
pyproject = true;

src = fetchPypi {
inherit pname version;

hash = "sha256-MniCe4A88Aah3yUfPhM3TH0m23eeWjMynMEXibgEvC0=";
};
build-system = [
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
pyproject = true;
src = fetchPypi {
inherit pname version;
hash = "sha256-MniCe4A88Aah3yUfPhM3TH0m23eeWjMynMEXibgEvC0=";
};
build-system = [
pyproject = true;
src = fetchPypi {
inherit pname version;
hash = "sha256-MniCe4A88Aah3yUfPhM3TH0m23eeWjMynMEXibgEvC0=";
};
build-system = [

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants