Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

workflows/check-nixf-tidy.yml: temporarily ignore sema-escaping-with #330454

Merged
merged 1 commit into from
Jul 27, 2024

Conversation

Aleksanaa
Copy link
Member

@Aleksanaa Aleksanaa commented Jul 27, 2024

Description of changes

Looks like there are more than enough "escaping with" in our codebase, and we cannot conveniently avoid it sometimes. @inclyc also said this is not very appropriate, and may improve the diagnosis for with in future.

This is partly tested locally.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

Copy link
Member

@inclyc inclyc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm OK with this decision because that diagnostic is indeed highly controversial.

I'm not familiar with jq scripts and thus cannot comment on implementation.

@Aleksanaa Aleksanaa marked this pull request as draft July 27, 2024 16:57
@Aleksanaa Aleksanaa marked this pull request as ready for review July 27, 2024 16:59
@Aleksanaa
Copy link
Member Author

Tested:

  1. No error reported by nixf ([]), works fine
  2. nixf only reports unrelated errors, works fine
  3. nixf reports matching error and unrelated errors, only unrelated errors are shown
  4. nixf reports matching error only, returning [], can pass [[ "$(...)" == '[]' ]]

Copy link
Member

@infinisil infinisil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good to me!

@infinisil infinisil merged commit 74aba63 into NixOS:master Jul 27, 2024
30 checks passed
@infinisil
Copy link
Member

For reference, here's a case of it being a bit too noisy and confusing:

2024-07-27_21-03

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants